Question

Table a:

PROTOCOL      VARCHAR2(20)

Table b:

YEAR          NUMBER(4)
MONTH         VARCHAR2(20)
PROTOCOL      VARCHAR2(20)
DATE1         DATE

My procedure code:

CREATE PROCEDURE his
    @Year NUMBER(4),
    @Month VARCHAR2(20)
AS
BEGIN
    SET NOCOUNT ON;

    BEGIN TRANSACTION trninsert
        DECLARE @@date DATE
        SET @@date = sysdate;
        INSERT INTO b (Year, month, date1, protocol)
        (select @Year, @Month, @@date,* from a)
    COMMIT TRANSACTION trninsert
    END TRY
    BEGIN CATCH
        ROLLBACK TRANSACTION trninsert
    END CATCH
END

I am using plsql developer and it is showing errors in procedure.

Answer 1

you’ve written this a mysql type syntax.

oracle would be:

CREATE PROCEDURE his(p_year  b.year%type,
                     p_month b.month%type)
AS
BEGIN
  INSERT INTO b (Year, month, date1, protocol)
  select p_year, p_month, sysdate, a.protocol
    from a;
  commit;
END;

though its bad form to commit in the procedure.

eg:

SQL> CREATE PROCEDURE his(p_year  b.year%type,
  2                       p_month b.month%type)
  3  AS
  4  BEGIN
  5    INSERT INTO b (Year, month, date1, protocol)
  6    select p_year, p_month, sysdate, a.protocol
  7      from a;
  8    commit;
  9  END;
 10  /

Procedure created.

SQL> insert into a values('prot a');

1 row created.

SQL> exec his(2012, 10)

PL/SQL procedure successfully completed.

SQL> select * from b;

      YEAR MONTH                PROTOCOL             DATE1
---------- -------------------- -------------------- ---------
      2012 10                   prot a               06-FEB-13

SQL>