Question

Take a look to that code

<?php

namespace Sestante\SestanteBundle\Controller;

use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Request;
use Sestante\SestanteBundle\Model\StrutturaManager;

class MainController extends Controller
{
    public function indexAction(Request $request)
    {
        return $this->render('SestanteSestanteBundle:Main:index.html.twig');
    }

    public function showLodgingsAction(Request $request)
    {
        $repo = $this->getDoctrine()->getRepository('SestanteSestanteBundle:Struttura');
        $usr = $this->get('security.context')->getToken()->getUser();
        $usrId = $usr->getId();
        $sm = new StrutturaManager($repo);
        $lodgingList = $sm->retrieveLodgingsFromUser($usrId);
        return $this->render('SestanteSestanteBundle:Main:showLodgings.html.twig',array('lodgingList' => $lodgingList));
    }
}

This is a controller for an application that I’ve been writing.

Take a look to showLodgingsAction. I’ve tryied to place all business logic into a model (StrutturaManager) that with a repository (that I’ve passed directly from controller because, as far I know, they’re available only here or via D.I.) query my db, do some elaboration and return a list that I’ll render onto a template.

First question: Is this “code separation” good, or exists a better way for do what I’m trying to do?

Second question: suppose that, now, I want to use an object of StrutturaManager type into indexAction. Remember that mine object want a repository. So, have I to declare again, and again, and again, all my object for every controller’s action where I want to use them? I suppose that must exist a smarter method but, at the moment, I don’t understand which.

Answer 1

Define StrutturaManager as a service and inject the EntityManager into it. This way the manager will have access to repositories you need and controllers won’t know about Doctrine nor repositories — which is a good practice.