Question

the analyze function tells me that there is a potential leak at mutableFetchResults here:

- (NSMutableArray *) getBookmarks
{
NSFetchRequest *request = [[NSFetchRequest alloc] init];
NSEntityDescription *entity = [NSEntityDescription entityForName:@"Bookmark" inManagedObjectContext:managedObjectContext];
[request setEntity:entity];
NSSortDescriptor *sortDescriptor = [[NSSortDescriptor alloc] initWithKey:@"title" ascending:YES];
NSArray *sortDescriptors = [[NSArray alloc] initWithObjects:sortDescriptor, nil];
[request setSortDescriptors:sortDescriptors];
[sortDescriptors release];
[sortDescriptor release];
NSError *error;
NSMutableArray *mutableFetchResults = [[managedObjectContext executeFetchRequest:request error:&error] mutableCopy];
[request release];


if (!mutableFetchResults) {
    NSLog(@"Error with fetch: %@", error );
    return nil;
}

return mutableFetchResults ;

}

Like this it works, but with a leak warning.
When I use autorelease NSMutableArray *mutableFetchResults = [[managedObjectContext executeFetchRequest:request error:&error] mutableCopy]; my app crashes without an error log.
How can I find out the problem here?

- (id)init
{
self = [super init];
if (self) {

    coreDataManager = [[CoreDataManager alloc] initWithDelegate:self];
    bookmarks = [coreDataManager getBookmarks];
  }
return self;
}

Answer 1

You need to retain anything you want to keep around, so your init method needs to retain the bookmarks:

bookmarks = [[coreDataManager getBookmarks] retain];

Then you can autorelease the mutableFetchResults variable before returning it.

Also, the Cocoa naming convention would have the getBookmarks method named bookmarks. 🙂