Question

The line if (!(cin.good())) cout << “No letters” << endl; keeps repeating nonstop if I type in letters, but the other ones work just fine. Can’t tell why.

#include <iostream>
#include <cstdlib>
#include <time.h>
#include <cstdio>
using namespace std;

int main()
{
    int x;
    cout << "Please enter a number\n";

    srand(time(0));
    int y = rand();

    while (x != y)
    {
        cin >> x;
        if (!(cin.good()))
           cout << "No letters" << endl;
        else if (x < y)
           cout << "Go higher" << endl;
        else if (x > y)
           cout << "Go lower" << endl;
        else
           cout << "You win!!" << endl;
    }
cin.get();
getchar();
return 0;

}

Answer 1

Your invalid input is sitting around in the input buffer. If you just want to throw it all out, you can do this:

...
if (!cin.good()) 
{
    cout << "No letters" << endl;
    cin.clear(); // clear error flags
    cin.sync();  // synchronize stream with input source
}
...