Question

the problem is the httpwebrequest method in my c# program. visual studio gives it a metric of 60, thats pretty lame.. so how can i program it more efficient? (:

my actual code:

public string httpRequest(string url)
    {
        HttpWebRequest request = (HttpWebRequest)WebRequest.Create(url);
        request.Method = "GET";
        request.Proxy = WebRequest.DefaultWebProxy;
        request.MediaType = "HTTP/1.1";
        request.ContentType = "text/xml";
        request.UserAgent = "Mozilla/5.0 (Windows; U; Windows NT 6.1; de; rv:1.9.2.12) Gecko/20101026 Firefox/3.6.12";

        using (HttpWebResponse response = (HttpWebResponse)request.GetResponse())
            using(StreamReader streamr = new StreamReader(response.GetResponseStream(), Encoding.UTF8))
                String sresp = streamr.ReadToEnd();
        return sresp;
    }

thanks for helping. 😉

Answer 1

Well, firstly I wouldnt let a number rule my code 🙂

However, using WebClient may simplify things quite a bit – less code to be counted. I’m not at a PC but that looks like a single DownloadString call, plus a few request headers.

http://msdn.microsoft.com/en-us/library/fhd1f0sw(v=VS.100).aspx

Oh, and add some using statements around all the IDisposable objects you create.