Question

The static analyzer is showing up a leak in this block of code (specifically the link with the copy in it):

- (void)parser:(NSXMLParser *)parser didEndElement:(NSString *)elementName namespaceURI:(NSString *)namespaceURI 
 qualifiedName:(NSString *)qName
{
    if ([elementName isEqualToString:@"item"]) 
    {
        [elements setObject:title forKey:@"title"];
        [elements setObject:date forKey:@"date"];
        [elements setObject:summary forKey:@"summary"];
        [elements setObject:link forKey:@"link"];

        [posts addObject:[elements copy]];
    }
}

I tried releasing the copied object but I still get the warning. Am I missing something?

Thanks

Answer 1

You created new copy which you don’t release.

This returns new elements object with ref count 1 which you are responsible to deallocate since you’ve just created a copy:

[elements copy];

In this line you add the new created copy to posts which looks like collection.
All collections retain new values, so you pass your new copy with ref count 1 and posts increase the ref count to 2 by retaining it.

[posts addObject:[elements copy]];

On release posts will send to each element release which will decrement ref count to 1 so elements does not get deallocated and you end up with memory leak.

Remove the copy and see if that helps:

[post addObject:elements];