Question

There are some common code patterns I find in other people’s Java code that can benefit from some simple refactoring.

What are your pet code pattern hates and their fixes (and the reason if it isn’t obvious)?

I have taken to liberty of answering with a couple of my own pet hates.

Answer 1

boolean someMethod() {
    if (<some test>) {
        return true;
    } else {
        return false;
    }
}

replace with

boolean someMethod() {
    return <some test>;
}

Guiding principles/patterns:

• less code is good
• redundant code is bad