Question

There’s another way to write this code ? I think it’s kinda unprofessional and messy

Basically the code submit a form by “Enter key” and mouse “Click” so there’s another way ?

$("#form-signup-login input#login-submit").click(function()
{
    doLogin();
});
$('input#login-request-username-email, input#login-request-password').keyup(function(e){
    if(e.keyCode == 13)
        doLogin();
});

Thanks for your time!

Answer 1

$("#login-submit").click(doLogin);

$('#login-request-password').keyup(function(e){
    if(e.keyCode === 13)
        doLogin();
});

Explanation:

1. No need to prepend id selectors with containers as they are unique on the page and you will fallback to the native getElementById method which is faster than the sizzle engine.
2. You can just use the function pointer in the first case, no need to build another call back function
3. I would just bind the keyup event on the password field rather than the username field as there is a natual flow there

Alternatively bind form submit which takes care of all this by default for you..

$("#form-signup-login").submit(doLogin);