Question

This is (a part of) my arrayValues:

<string-array name="securityValues">
<item name="wep">"capabilities LIKE '%WEP%'"</item>
<item name="wpa">"capabilities LIKE '%WPA%'"</item>
<item name="free">"capabilities NOT LIKE '%WPA%' AND capabilities NOT LIKE '%WEP%' AND capabilities NOT LIKE '%WPS%'"</item>
<item name="all">"1"</item>

and this is a part of my preferences.xml

 <ListPreference 
    android:key="visualizzazione_marker_security"
    android:title="Sicurezza Wifi da visualizzare"
    android:summary="Scegli con quale protocollo di sicurezza vuoi che siano visualizzate le wifi"
    android:entries="@array/security"
    android:entryValues="@array/securityValues"

/> 

and finally my code:

    @Override
  public boolean onCreateOptionsMenu(Menu menu) {
    menu.add(Menu.NONE, 0, 0, "Only free wifi");
    menu.add(Menu.NONE, 1, 1, "All wifi");
    return super.onCreateOptionsMenu(menu);
  }

switch (item.getItemId()) {
    case 0:

        Editor edit = PreferenceManager.getDefaultSharedPreferences(this).edit();
        edit.putString("visualizzazione_marker_security","capabilities NOT LIKE \'%WPA%\' AND capabilities NOT LIKE \'%WEP%\' AND capabilities NOT LIKE \'%WPS%\'").apply();
        edit.commit();
        Toast.makeText(this, "Wait 30 seconds please", Toast.LENGTH_LONG).show();
        case 1:
            Editor edit1 = PreferenceManager.getDefaultSharedPreferences(this).edit();
        edit1.putString("visualizzazione_marker_security","1").apply();
        edit1.commit();
        Toast.makeText(this, "Wait 30 seconds please", Toast.LENGTH_LONG).show();
        return true;
}

why case0 not apply the modify? The value in preferences always change to 1!

Answer 1

You are missing a break; statement in your case block. So case 0 gets overwritten by case 1.

switch (item.getItemId()) {
    case 0:
        Editor edit = PreferenceManager.getDefaultSharedPreferences(this).edit();
        edit.putString("visualizzazione_marker_security","capabilities NOT LIKE \'%WPA%\' AND capabilities NOT LIKE \'%WEP%\' AND capabilities NOT LIKE \'%WPS%\'").apply();
        edit.commit();
        Toast.makeText(this, "Wait 30 seconds please", Toast.LENGTH_LONG).show();
        break;

    case 1:
        Editor edit1 = PreferenceManager.getDefaultSharedPreferences(this).edit();
        edit1.putString("visualizzazione_marker_security","1").apply();
        edit1.commit();
        Toast.makeText(this, "Wait 30 seconds please", Toast.LENGTH_LONG).show();
        return true;
}