Question

This is my current exception handling code.

Take especial note of the line throw e; marked with ***.

try
{
  //some code that could cause exception
}
catch (FaultException e) //first catch a particular type of exception only
{
  if (Regex.IsMatch(e.Message, "something")) //satisfying a particular condition
  {
    Console.WriteLine("Particular exception occurred.");
    return;
  }
  else
    throw e; // <-- *** Problem! Not getting caught by the "catch" below.
}
catch (Exception e) //catch all other exceptions
{
  Console.WriteLine("General exception ocurred");
  return;
}

The problem is this: If the throw e; // <-- *** occurs, it is not getting caught by the final catch. Instead, the app just crashes as if the exception was not handled.

How can this be fixed in the simplest possible way?

You see in the first catch that I’m only interested in actually handling FaultException exceptions satisfying a particular condition, but leave all others (both FaultException exceptions not satisfying the condition and exceptions that are not FaultException) to the final catch. Unfortunately, this is not working properly.

I’m on .NET 4.

Answer 1

Only one catch block is executed per try block.

I would rewrite the catch block as:

catch (Exception e)
{
    if (e is FaultException && Regex.IsMatch(e.Message, "something"))
    {
        ....
    }
    else // all other exceptions
    {
        ....
    }
}