Question

This is my first post here, recently i have been working with JSF2.0 with primefaces. we have this requirement to export PDF in our application. initially we used primefaces default dataexporter tag. but the format was simply terrible. so, i used itext to generate PDF. we have like upto 15 datatables in our app, and all of them require PDF exporting. i have created a method called generatePDF which creates the PDF using Itext for all the tables.

 Interface PDFI {
 public void setColNames();
 public void setColValues();
 public void setContentHeader();

 }
Class DataEx  {
    public void generatePDF(ActionEvent event) {
        // generate pdf...
    }

}

consider i have a Datatable A in the view
Datatable A …
bean behind this datatable..

Class BeanA implements PDFI {
    //implemented methods

    }

} 
Class BeanB implements PDFI {
 //implemented methods

 }

and behind another datatable B, i do the same thing as above ..
so, my question here is, is this considered duplicate code ?? and also, is this the efficient way to do this.
any help is appreciated.
thanks ina dvance

Answer 1

Rule of thumb that I use before re-factoring duplicate code- when part of the code in one place have a bug- are you need to change the other one to? cause you probably will forget

in your case, it’s look like you have duplicate code block. I’ll consider add the require parameters to generatePDF so it’ll do all work in one place.