Home/ Questions/Q 55327
In Process

The Archive Base Latest Questions

Editorial Team
  • 0
Asked: 2026-05-10T17:21:36+00:00

This is the way I read file: public static string readFile(string path) { StringBuilder

  • 0

This is the way I read file:

    public static string readFile(string path)     {         StringBuilder stringFromFile = new StringBuilder();         StreamReader SR;         string S;         SR = File.OpenText(path);         S = SR.ReadLine();         while (S != null)         {             stringFromFile.Append(SR.ReadLine());         }         SR.Close();         return stringFromFile.ToString();     }

The problem is it so long (the .txt file is about 2.5 megs). Took over 5 minutes. Is there a better way?

Solution taken

    public static string readFile(string path)     {         return File.ReadAllText(path);      }

Took less than 1 second… 🙂

Share

Leave an answer

You must login to add an answer.

Need An Account,

1 Answer

  1. Leaving aside the horrible variable names and the lack of a using statement (you won’t close the file if there are any exceptions) that should be okay, and certainly shouldn’t take 5 minutes to read 2.5 megs.

    Where does the file live? Is it on a flaky network share?

    By the way, the only difference between what you’re doing and using File.ReadAllText is that you’re losing line breaks. Is this deliberate? How long does ReadAllText take?

    • 0