Question

This line of code:
[mymutabledict setObject:myclassobj forKey:myclassobj.myidstring];

Is giving this error:

*** -[NSCFString hash]: message sent to deallocated instance 0x3c14610

I put in a breakpoint on that line and I’ve checked and all 3 objects (mymutabledict, myclassobj, and myclassobj.myidstring) are correctly allocated and visible and correctly there in the debugger. What else could be causing this error? Could it be something to do with the object or keys I used to put previous items into the dictionary?

I’ve even checked and the key used does not match any of the previously entered keys.

For a little extra info: I’m loading objects from an SQL database to a mutable dictionary in memory. This code has all worked fine on several sets of sample data for weeks and just today this came up with one specific copy of the DB. Thanks!

Answer 1

You seem to be calling release too many times on something. Add the following code just above that line:

for (NSString *key in mymutabledict) {
    NSLog(@"Key %@ maps to %@.", key, [mymutabledict objectForKey:key]);
}
NSLog(@"About to add %@", myclassobj);
NSLog(@"   with key %@", myclassobj.myname);

… and look for the crashing object.

Keys are copied, not retained, when objects are added to an NSDictionary / NSMutableDicitonary object. If you’re pulling the keys from the dictionary and releasing them (e.g., calling [key release] in the above code or on string objects acquired via [mymutabledict allKeys]), that might do it.