Question

This program takes the first number in a file and indicates how many numbers are going to be after it, then does various other things with the numbers that follow.

It seems like scanf is causing an infinite loop when trying to read from the file. WHen I run the program not even the check at 1 works

Here is the code:

#include <stdio.h>

int main(void) {
        int N, a, n;
        int x=0;
        int t=0;
        printf("1"); //Check
        scanf("%d", &N);
        printf("2"); //Check
        int nums[N];
        int i;
        printf("%d", &N);  //Check
        for (i=0; i<N; i++)
        {
                scanf("%d", &nums[i]);
                t+=nums[i];

                if (nums[i] > x) x=nums[i];

                if (i=0 || nums[i] < n) n = nums[i];
        }
        a = t/N;   
        printf("Number Processed: \t%d\n", &N);
        printf("Maximum: \t%d\n", &x);
        printf("Minimum: \t%d\n", &n);
        printf("Total: \t%d\n", &t);
        printf("Average: \t%d\n", &a);
}

The way i run the program is

gcc -lab16
./a.out <in1

where in1 is text and has the numbers

7
6
-30
90
3903
-934
443
445

Thanks for your time.

Answer 1

if (i=0 || nums[i] < n) n = nums[i];

you are assigning i = 0, so the loop never realy advances! You probably wanted i == 0. This is causing the infinite loop.

Other issue: int nums[N]; – if you want an array of dynamic [determined in run-time] size, you will probably need to malloc() it.

Update: note that int nums[N] is valid in C99, so if your assigment is assuming C99 you should not worry about this issue. Otherwise – malloc() will be needed:

int* nums = (int*) malloc(sizeof(int) * N)

And don’t forget to free(nums) before the program ends, or you will get memory leak.