Question

This title begs for more explanation.

Basically, I’m rolling an API that wraps a web service in a nice heirarchical model. This model exposes things in the form:

var obj = MyRemoteResource.GetForId(1234, SourceEnum.ThatSource);
ApiConsumerMethod(obj.SomeProperty);  //SomeProperty is lazily loaded, and often exposes such lazily loaded properties itself
... etc ...

Where many different RemoteResources* (each with many properties exist). There’s really aggresive cacheing going on, and request throttling to prevent inadvertantly DOS’ing the servers (and getting the IP of the caller banned).

I’ve got all this code working, but I’m not doing much in the way of error handling at the moment. Basically, if the consumer of an API provides an invalid ID, the web server is down, a connection times out, or any other of a plethora of request layer errors occur an exception just percolates up when a property is accessed.

I consider this far less than ideal.

So my question is, how should I wrap these errors up so that it is convenient for a user of this API to manage them?

Some routes I have considered:

• Just wrap all exceptions in some API defined ones, and document them as thrown.
• Expose a static ErrorHandler class that allows a user to register notification callbacks for specific errors; falling back to the above behavior when no registration has been made for specific errors.**
• Null properties on error, and set a LastErrorCode.

Each of these approachs have strengths and weaknesses. I’d appreciate opinons on them, as well as alternatives I haven’t thought of.

If it impacts the discussion at all, the platform class throwing these exceptions is WebClient. Furthermore, usage of WebClient is sufficiently abstract that it could easily be replaced with some other download scheme if needed.

_{*Which is to say, many different classes}

_{**This would be… wierd. But it maps to the global nature of the failure. This is my least favorite idea thus far.}

Answer 1

I wouldn’t implement fancy error technologies (like events and stuff like this). It’s not easy to judge where and how to use exceptions, but this is no reason to implements other stuff.

When you request an object by an id which doesn’t exist, what do you have to tell the caller about this? If you just return null, the client knows that it doesn’t exist, there is nothing more to say.

Exceptions force the caller to care about it. So they should only be used where the caller is expected to do something special. Exception can provide the information why something didn’t work. But if it is an “error” the user could also ignore, an exception is not the best choice.

There are two common alternatives to exceptions.

• Use return values which provide information about the result of an action. For instance, logon could return a LogonResult instead of throwing an exception.
• Write two methods, one throwing an exception, and one (Try…) returning a boolean. The caller decides if it wants to ignore the “error” or not.