Question

Trying to clean up some code. I have a button that has the following inline JS

<input id="lookup" type="submit" name="lookup" value="Search" onclick="changestart('1')" />

I would like to change the onclick to a jQuery click funnction but am getting no success. Here is the “changestart” function

function changestart(direction) {
    var rowsElement  = $("#maxrows");
    var rowsValue    = parseInt(rowsElement.val());
    var startElement = $("#startID");
    var value        = parseInt(startElement.val());
    startElement.val(direction == "forward" ? value + rowsValue : direction == "back" ? value - rowsValue : 1);
}

$("#previous").click(function(){changestart('back');});
$("#next").click(function(){changestart('forward');});

I’ve tried

$("#lookup").click(function(){changestart.val(1);});

but it doesn’t work.

Answer 1

Since your code defaults down to 1 anyway, you can just do this:

$("#lookup").click(changestart);

There’s no .val() method on functions, and the argument you’re passing doesn’t matter anyway, anything except "forward" and "back" are 1, so you can pass with no argument as well, which is what the above code does.