Question

Update edition:

So, I’m trying to get this code to work without using scanf/fgets. Gets chars from the user, puts it into a pointer array using a while loop nested in a for loop.

#define WORDLENGTH 15
#define MAXLINE 1000

int main()
{
    char *line[MAXLINE];
    int i = 0;
    int j;
    int n;
    char c;


    for (n=0; c!=EOF; n){
        char *tmp = (char *) malloc(256);
        while ((c=getchar())!=' '){
            tmp[i]=c;     // This is no longer updating for some reason. 
            i++;
            }
        line[n++]=tmp; // 
        i=0;
        printf("\n%s\n",line[n]); //Seg fault here
    }

    for(j = 0; j (lessthan) n; j++){
        printf("\n%s\n", line[j]);
        free (line[j]);
    }

    return 0;

So, now I’m getting a seg fault. Not sure why tmp[i] is not updating properly. Still working on it.

I’ve never learned this much about programming during the entire semester so far. Please keep helping me learn. I’m loving it.

Answer 1

sizeof(WORLDLENGTH), for one, is wrong. malloc takes an integer, and WORLDLENGTH is an integer. sizeof(WORLDLENGTH) will give you the size of an integer, which is 4 if you compile for a 32-bit system, so you’re allocating 4 bytes.

Btw – while ((c=getchar())!=' '||c!=EOF) – what’s your intent here? A condition like (a!=b || a!=c) will always return true if b!=c because there is no way a can be both b and c.

And, as others pointed out, you’re printing out line[i], where i is always 0. You probably meant line[n]. And you don’t terminate the tmp string.

And there’s no overflow checking, so you’ll run into evil bugs if a word is longer than WORDLENGTH.