Question

Using sharedpreferences I run this method:

private Button button1;
private Button button2;
private TextView textView1;

@Override
public void onCreate(Bundle savedInstanceState){ 
  super.onCreate(savedInstanceState);
  setContentView(R.layout.activity_main);
checkIndex();

// here save preferences if there are not
// after second start of program, checkIndex(); goes to that crash

public void checkIndex(){
    SharedPreferences prefs = getSharedPreferences(PRIVATE_PREF, 0);
    String index = prefs.getString("scelta", "");
    if (index == ""){
 index();
    }
    else {

        String scelta = prefs.getString("scelta", "");
        int a = prefs.getInt("arraystart", 0);
        int b = prefs.getInt("arrayend", 0);

        int size = prefs.getInt(prog +"_size", 0);
        String prog[] = new String[size];
        for(int i=0; i<prog.length; i++)

         prog[i] = prefs.getString(prog + "_" + i, null);

        String titolo = prefs.getString("titolo", "");
        int x = prefs.getInt("x", 0);

        textView1.setText(""+a+" "+b+" "+titolo);

I’ve a NullPointer exception by textView1 and I don’t understand why! (I spent many many hours but nothing)… why? thanks!

logcat:

11-30 21:49:42.806: E/AndroidRuntime(3739): FATAL EXCEPTION: main
11-30 21:49:42.806: E/AndroidRuntime(3739): java.lang.RuntimeException: Unable to start activity ComponentInfo{com.example.perledisaggezza/com.example.perledisaggezza.MainActivity}: java.lang.NullPointerException
11-30 21:49:42.806: E/AndroidRuntime(3739):     at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2059)
11-30 21:49:42.806: E/AndroidRuntime(3739):     at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2084)
11-30 21:49:42.806: E/AndroidRuntime(3739):     at android.app.ActivityThread.access$600(ActivityThread.java:130)
11-30 21:49:42.806: E/AndroidRuntime(3739):     at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1195)
11-30 21:49:42.806: E/AndroidRuntime(3739):     at android.os.Handler.dispatchMessage(Handler.java:99)
11-30 21:49:42.806: E/AndroidRuntime(3739):     at android.os.Looper.loop(Looper.java:137)
11-30 21:49:42.806: E/AndroidRuntime(3739):     at android.app.ActivityThread.main(ActivityThread.java:4745)
11-30 21:49:42.806: E/AndroidRuntime(3739):     at java.lang.reflect.Method.invokeNative(Native Method)
11-30 21:49:42.806: E/AndroidRuntime(3739):     at java.lang.reflect.Method.invoke(Method.java:511)
11-30 21:49:42.806: E/AndroidRuntime(3739):     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:786)
11-30 21:49:42.806: E/AndroidRuntime(3739):     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553)
11-30 21:49:42.806: E/AndroidRuntime(3739):     at dalvik.system.NativeStart.main(Native Method)
11-30 21:49:42.806: E/AndroidRuntime(3739): Caused by: java.lang.NullPointerException
11-30 21:49:42.806: E/AndroidRuntime(3739):     at com.example.perledisaggezza.MainActivity.checkIndex(MainActivity.java:480)
11-30 21:49:42.806: E/AndroidRuntime(3739):     at com.example.perledisaggezza.MainActivity.onCreate(MainActivity.java:149)
11-30 21:49:42.806: E/AndroidRuntime(3739):     at android.app.Activity.performCreate(Activity.java:5008)
11-30 21:49:42.806: E/AndroidRuntime(3739):     at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1079)
11-30 21:49:42.806: E/AndroidRuntime(3739):     at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2023)
11-30 21:49:42.806: E/AndroidRuntime(3739):     ... 11 more
11-30 21:51:08.107: E/Trace(3796): error opening trace file: No such file or directory (2)

Answer 1

You are calling checkIndex() before doing textView1 = (TextView)findViewById(R.id.textView1); You need to first initiatlize textView1 then you can work with it, otherwise checkIndex() is working with a null reference. Therefore, you need to add textView1 = (TextView)findViewById(R.id.textView1); before checkIndex();