Question

- (void)viewDidLoad //In this scenario it only gets called once, but in other bits of code with same property initialisation it might be called more than once
{
deleteButton = [[UIBarButtonItem alloc] initWithTitle:@"" style:UIBarButtonItemStylePlain target:self action:@selector(deleteModelTapped:)]; //Is this leaking?
    self.deleteButton.image = [UIImage imageNamed:[Configuration getDeleteIconName]];
}

@property (nonatomic, retain) IBOutlet UIBarButtonItem *deleteButton;

- (void)dealloc 
{    
    [deleteButton release];
    [super dealloc];
}

Answer 1

nop, but write like this maybe better

- (void)viewDidLoad
{
    self.deleteButton = [[[UIBarButtonItem alloc] initWithTitle:@"" style:UIBarButtonItemStylePlain target:self action:@selector(deleteModelTapped:)] autorelease]; 
    self.deleteButton.image = [UIImage imageNamed:[Configuration getDeleteIconName]];
}

the setProperty expand may like this

- (void)setProperty:(XXX*)p
{
    if ( property != p )
    {
        [property release];
        property = [p retain];
    }
}

the “leak” maybe use “[UIImage imageNamed:]”; 🙂