We are attempting to upload our addon to the Mozilla “addon” store. We have received a warning about using innerHTML. Is this a deal breaker in the review process? I don’t want to submit it yet without maybe getting some feedback on this.
innerHTML should not be set dynamically
Warning: Due to both security and performance reasons, innerHTML
should not be set using dynamic values. This can lead to security
issues or fairly serious performance degradation.
I use innerHTML a few times in my script just to change the wording of links that are created by the addon.
My experience is that generally they prefer you resolve the warnings, unless there is a good reason for an exception. In this case, you can easily use the DOM API instead. Probably, textContent will work for you.