We are running into unusually high memory usage issues. And I observed that many places in our code we are pulling 100s of records from DB, packing it in custom data objects, adding it to an arraylist and storing in session. I wish to know what is the recommended upper limit storing data in session. Just a good practice bad practice kind of thing.
I am using JRockit 1.5 and 1.6GB of RAM. I did profiling with Jprobe and found that some parts of app have very heavy memory footprint. Most of this data is being into session to be used later.
That depends entirely on how many sessions are typically present (which in turn depends on how many users you have, how long they stay on the site, and the session timeout) and how much RAM your server has.
But first of all: have you actually used a memory profiler to tell you that your “high memory usage” is caused by session data, or are you just guessing?
If the only problem you have is “high memory usage” on a production machine (i.e. it can handle the production load but is not performing as well as you’d like), the easiest solution is to get more RAM for the server – much quicker and cheaper than redesigning the app.
But caching entire result sets in the session is bad for a different reason as well: what if the data changes in the DB and the user expects to see that change? If you’re going to cache, use one of the existing systems that do this at the DB request level – they’ll allow you to cache results between users and they have facilities for cache invalidation.