Question

Well, something going wrong here. I type username and password which are exist in my DB. It should echo this string in such situations

need to activate

but it echo this

You need to reg

init.php

<?php
    //error_reporting(0);
    session_start();

    require 'dbconnect.php';//this works okay so i wouldn't post this file code
    require 'users.php';

    $errors = array();
?>

users.php

        <?php

        function user_exists($username){
            $username = mysql_real_escape_string($username);

            $query = mysql_query("SELECT COUNT('user_id') FROM `users` WHERE 'username' = '$username'");

            if (!$query) {
                die('Could not query:' . mysql_error());
            }

            return (mysql_result($query, 0) == 1) ? true : false;

        }

        function user_active($username){

            $username = mysql_real_escape_string($username);

            $querytoo = mysql_query("SELECT COUNT('user_id') FROM `users` WHERE 'username' = '$username' AND 'active' = 1");

            if (!$querytoo) {
                die('Could not query:' . mysql_error());
            }

            return (mysql_result($querytoo , 0) == 1) ? true : false;

        }
    ?>

login.php

<?php
include 'init.php';


if(empty($_POST) === false){
    $username = $_POST['username'];
    $password = $_POST['password'];

    if(empty($username) === true || empty($password) === true){
        $errors[]='You need to enter a username and password';
    } 
    elseif(user_exists($username) === false){
        $errors[]='You need to reg';
    } 
    elseif(user_active($username) === false){
        $errors[]='need to activate';
    } 
    else {
    //
    }

    print_r($errors);
}



?>

part of html

<form action="login.php" method = "post">
                    <ul id="login">
                        <li>
                            username:<br>
                            <input type="text" name="username" size="30" value=""/></li>
                        <li>password:<br>
                            <input type="password" name="password" size="30" value=""/></li>
                        <li><input type = "submit" value ="Log in"></li>
                        <li>
                            <a href="register.php"> Register</a>
                        </li>
                    </ul>

P.S.
text of querys is works fine, i checked it in mysql. in php code when I type “ instead of ” here

SELECT COUNT(‘user_id’) FROM users WHERE ‘username’ = ‘$username’
AND ‘active’ = 1

appears

‘Could not query:’

thing

and i tried elseif and else if things so i don’t think that problems is there

Answer 1

Your SQL is wrong. You are comparing a static strings to your value, not a column name:

    SELECT COUNT('user_id') FROM users WHERE 'username' = '$username' AND 'active' = 1

should be

SELECT COUNT(user_id) FROM users WHERE username = '$username' AND active = 1

Note that I removed the ‘ from the column names. It is also valid to use backticks:

SELECT COUNT(`user_id`) FROM users WHERE `username` = '$username' AND `active` = 1