Question

We’ve just updated PHP on our server, for the most part everything is fine, but the mssql_ functions aren’t supported any more unfortunately. I’ve tried to update our previous class:

$connection['server'] = 'server, port';
$connection['user'] = 'user';
$connection['pass'] = 'pass';
$connection['db'] = 'db';

class mssqlClass {
    function connect($dbhost = NULL){
        global $connection;
        if(! ISSET ($dbconnect)){
            $dbconnect = mssql_Connect($connection['server'], $connection['user'], $connection['pass'], true);
        }
        if(! $dbconnect){
            return 'Failed to Connect to Host';
        }else{
            $select = mssql_select_db($connection['db'], $dbconnect);
            if(! $select){
                return 'Failed to select Database';
            }else{
                return $dbconnect;
            }
        }
    }

    function getData ($query){
        $this->data_array = array();
        $result = mssql_query($query);
        while ($row = mssql_fetch_assoc($result)) {
                    $this->data_array[] = $row;                                                    
        }
        $m = $this->data_array;                     
        return $m;
    }    
    function query($query){           
        $result = mssql_query($query) or die("Query didn't work");
    }
}

To be compliant with sqlsrv_, and whilst I can connect to the database without any issues, it won’t return any data!:

class mssqlClass {
    function connect($database = 'Db') {
        $mssql_server = 'server';
        $mssql_data = array("UID" => 'uid',
                        "PWD" => 'pwd',
                        "Database" => $database);
        if(! ISSET ($dbconnect)){
            $dbconnect = sqlsrv_connect($mssql_server, $mssql_data);
        }
        if(! $dbconnect){
            return 'Failed to connect to host';
        }
    }

    function getData ($query) {
        $result = sqlsrv_query($db->connect, $query);
        while ($row =  sqlsrv_fetch_array($result)) {

                    $this->data_array[] = $row;                                                    
        }
        $m = $this->data_array;                     
        return $m;
    } 
    function query($query) {           
        $result = sqlsrv_query($query) or die("Query didn't work.");
    }
}

ps. Example usage is as follows:

$db = new mssqlClass();
$conn = $db->connect('DATABASE');

$query = "SELECT * FROM Table";
$result= $db->getData($query);

So sorry for the horrible amount of code – I can edit it down to just the getData function if that’s easier? Thank you!!

Answer 1

I’ve made some changes in your class:

<?php

class mssqlClass {

    protected $connection = null;

    public function connect($database = 'Db') {
        // we don't need to connect twice
        if ( $this->connection ) {
            return;
        }
        // data for making connection            
        $mssql_server = 'gc-hr01';
        $mssql_data = array("UID" => 'uid',
                        "PWD" => 'pwd',
                        "Database" => $database);
        // try to connect                    
        $this->connection = sqlsrv_connect($mssql_server, $mssql_data);
        if(! $dbconnect){
            return 'Failed to connect to host';
        }
    }

    public function getData ($query) {
        // reset results; is this really needed as object's variable? Can't it be just local function's variable??
        $this->data_array = array();
        $result = $this->query($this->connection, $query);
        while ($row = sqlsrv_fetch_array($result)) {
            $this->data_array[] = $row;                                                    
        }
        return $this->data_array;                     
    }

    public function query($query) {           
        $result = sqlsrv_query($query) or die("Query didn't work..");
    }

}