Question

What am I doing wrong with the syntax of these If/Else statements
I’m pretty sure it has something to do wiht my curly bracket placement.
All of the examples in my book only contain really primitive/simple examples (not to say that this code isn’t simple; b/c it is). I guess my general question would also be how do you separate these two separate statements. When I execute it seems that the two separate functions are blending together.

  //
    tens = rand / 10;
    if (tens =  2){
            cout << "twenty ";
    else if (tens = 3)
            cout << "thirty ";
    else if (tens = 4)
            cout << "forty ";
    else if (tens = 5)
            cout << "fifty ";
    else if (tens = 6)
            cout << "sixty ";
    else if (tens = 7)
            cout << "seventy ";
    else if (tens = 8)
            cout << "eighty ";
    else if (tens = 9)
            cout << "ninety ";
    }

    //
    ones = rand % 10;
    if (ones =  0){
            cout << "\n";
    else if (ones = 1)
            cout << "one\n";
    else if (ones = 2)
            cout << "two\n";
    else if (ones = 3)
            cout << "three\n";
    else if (ones = 4)
            cout << "four\n";
    else if (ones = 5)
            cout << "five\n";
    else if (ones = 6)
            cout << "six\n";
    else if (ones = 7)
            cout << "seven\n";
    else if (ones = 8)
            cout << "eight\n";
    else if (ones = 9)
            cout << "nine\n";
    }

Answer 1

I think, for this particular problem if-else isn’t even required!

I would rather recommend this solution:

const char *stens[] = {"", "", "twenty", "thirty", "forty", "fifty",
                               "sixty", "seventy", "eighty", "ninty"};
const char *sones[] = {"", "one", "two", "three", "four", "five", 
                               "six", "seven", "eigth", "nine"};

//make sure  0<= rand <= 99
 cout << stens[ rand / 10 ] << " " << sones[ rand % 10 ] << endl;

Online Demo : http://www.ideone.com/K7HxS

As for the problem you’re facing with if-else, you’re using assignment operator, rather than equality, as everyone already have pointed out.