Question

What i’m trying to do is create a template array class that will store values of a data type into an array. I have it working fine with int values, however working with string objects things start to break down.

I’ve taken out the block of code and tried it on it’s own and I do get the same error. I’m sure I’ve learnt this, and I’m almost positive that the answer is something simple, trying to wrap my head around the pace in which we’re learning c++ is a little crazy at times!

My best guess right now, is that I would need to tokenize the string and look for spaces. I tend to over think things though which lead to more confusion – thus me seeking out a answer here!

The code:

// Test String: Hello World this is a String Object
int stringSize = 7;
int count = 0;

string s[stringSize];

cout << "\nEnter " << stringSize << " one-word string values:\n";

while (count < stringSize) {

    string tmpVal;

    cin >> tmpVal;
    s[count] = tmpVal;

    count ++;
}

Answer 1

string s[stringSize]; is illegal because stringSize is not a constant. You must either use dynamic memory (i.e. string* s = new string [stringSize];), include stringsize as a template argument (don’t do this, it doesn’t actually solve the problem), use a fixed size value, or use an existing structure (I’d suggest vector, as in Bill’s answer). The code below works fine on my compiler:

int main(int argc, char *argv[]) {
int stringSize = 7;
int count = 0;
string* s = new string [stringSize];
cout << "\nEnter " << stringSize << " one-word string values:\n";
while (count < stringSize) {
    string tmpVal;
    cin >> tmpVal;
    s[count] = tmpVal;
    count ++;
    }
    delete[] s;
}