Question

What would be the best practice to do this :

    class AwesomeClass {

            // Code

            public function test()
            {
                    foreach($objects->values as $v)
                    {
                            New SuperClass($v);
                    }

                    return $objects;
            }

    }

    class SuperClass {
            public function __construct($arg2)
            {
                    return trim($arg2);        
            }
    }

    $rule_the_world = New AwesomeClass($arg1);

    $king = $rule_the_world->test();

The previous code is obviously not working, I think I’m missing some major point of PHP OO.

Answer 1

It’s very difficult to decipher what you’re asking for, and the code you have is not recoverable.

---

Code Errors

There are several errors in your code that are illogical:

• AwesomeClass has no constructor.

  • This makes passing arg1 to new AwesomeClass meaningless
  • arg1 is never initialized

• In AwesomeClass::test(), objects is never initialized and has no member value.

  • You will get a warning since it’s not traversable

• New SuperClass (should be new, per standards) does nothing.

• __construct() cannot return a value.

---

What You May Want

What I think you’re going for is something like this:

class AwesomeClass implements IteratorAggregate {
   private $arg1;

   public function __construct(array $arg1) {
      $this->arg1 = $arg1;
   }

   public function getIterator() {
      return new ArrayIterator($this->arg1);
   }
}

class SuperClass {
   private $arg2;

   public function __construct($arg2) {
      $this->arg2 = $arg2;
   }

   public function __toString() {
      return "$this->arg2\n";
   }
}

$rule_the_world = new AwesomeClass(array('one', 'two', 'three'));
foreach ($rule_the_world as $sc) {
   $sc = new SuperClass($sc);
   echo $sc;
}

Note that it is redundant to create an ArrayIterator instance when arg1 must already be an array, this is just an example.