Question

When adding a controller in ASP.Net MVC 3 using “Controller with Read/Write actions and views, using EntityFramework” as template, it generates a class as follows:

namespace Project.Controllers
{ 
    public class Default1Controller : Controller
    {
        private ProjectEntities db = new ProjectEntities();

        ...
    }
}

Now, I would like to know if it would be a good practice to change this so that my Controller would inherit a custom base controller that would instantiate ProjectEntities. It would look as follows:

BaseController:

namespace MatchesHorsConcours.Controllers
{
    public class BaseController : Controller
    {
        protected MatchesEntities db = new MatchesEntities();
        ...
    }
}

Other controllers:

namespace Project.Controllers
{ 
    public class Default1Controller : BaseController
    {
    ...
    }
}

Answer 1

No absolutely not. It makes totally untestable. Please use repository pattern and constructor injection if possible: Repository Pattern vs DAL