Home/ Questions/Q 6912681
In Process

The Archive Base Latest Questions

Editorial Team
  • 0
Asked: 2026-05-27T09:07:21+00:00

When I run my application I am getting the following error: ArgumentError in StatesController#filter

  • 0

When I run my application I am getting the following error: 

ArgumentError in StatesController#filter

wrong number of arguments (0 for 1)

My controller looks like this: 

class StatesController < ApplicationController
    def filter(my_string)

        @new_array = []
        @new_array = state.each {|x| if /#my_string/i =~ x then puts x end}
        return @new_array

    end

end

And my view looks like this:

 <?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
    "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
  <head>
    <title>States</title>
  </head>

  <body>

        <% States.filter(params[:substring]) %>
        <p><%= @new_array.each %></p>
        <% if @new_array.size = 0 %>
        <p>No matches!</p>

    </body>

</html>

What wrong with my code?

thanks so much

Share

Leave an answer

You must login to add an answer.

Need An Account,

1 Answer

  1. Editorial Team

    The filter method you have in the StatesController is an action. Such actions do not accept parameters. A better way to achieve what you are trying to do would be to create a model called State like so. And add the filter method to it:

    # app/models/state.rb
class State
  def filter(params[:my_string])
    @new_array = []
    @new_array = state.each {|x| if /#my_string/i =~ x then puts x end}
    return @new_array
  end
end

    In your controller, you should now have something like the following:

    class StatesController < ApplicationController
  def filter
    @states = State.filter(params[:sub_string])
  end
end

    Then in the corresponding view: 

    <% if @states.empty? %>
  <p>No matches!</p>
<% else %>
  <p>
    <% @states.each do |state| %>
      <%= state %>
    <% end %>
  </p>
<% end %>

    What this does is uses the model to load an array into an instance variable. This instance variable (started with the @) is accessible in the view that is rendered in the controller action. The action we are using is specified as filter.

    In the view, I check if there are any results in the array by using the empty? method. Otherwise i just loop through the array.

    Now, this will only work provided you have the params[:sub_string] in the headers. So you will need to make sure you have something like ?sub_string=mystring in the url.

    Given your question, and your code layout, I would assume you are fairly new to rails. I really recommend having a good read through the getting started guide here: http://guides.rubyonrails.org/getting_started.html

    • 0