Question

When writing getter/setters in classes, should the setters be private methods?

It might seem a bit redundant to have to write another method to set a variable but it seems like that might allow for a more maintainable code structure.

Answer 1

In General, I don’t recommend “private” access for any member, maybe “protected”. Usually, you or other programmer may require it in a descendant class.

Long Boring Descriptive Answer

Now, for accessors (“getters & setters”), its also depends on the syntax and implementation of properties on the programming language.

For Example, C++, or Java, I consider not have “real properties”, and accesors, maybe required to have the same scope as the properties. (Unless using a template for properties).

C# & Delphi (Lazarus) have properties implemented, but, I don’t like the way C# declare the accesors.

There are cases, where you may want a property not to be public, maybe “protected” or “package protected”, and its accesors, the same access than the property.

I just work in some code in Object Pascal. Most properties where “public”, and its accesors “protected”, but, want to migrate that code to c++ or Java, so, I make the accesors “public”, as well.

Quick Short Answer

Same access as the property, but, depends on the syntax of properties.