Question

Which is a good practice in implementing click listener and why? Or is there a better way other than the two? Thanks.

First :

    sampleButton.setOnClickListener(new View.OnClickListener(){
        public void onClick(View v){
            // do something
        }

    });

Second : implement OnClickListener then override onClick method?

Answer 1

You’re technically doing the 2nd thing with the 1st one. The 1st case uses whats called an anonymous class which implements OnClickListener, but since is anonymous, doesn’t have a class name and isn’t editable from external classes. Explicitably implementing OnClickListener is useful if you expect to use the same onClick functionality in multiple different locations, or if the click code is long