Question

Which of the following is correct (or does it matter).

Connection conn = null;
conn = DriverManager.getConnection (url, userName, password);
Statement st = conn.createStatement();
while (a.b()) {

  st.executeUpdate(blah blah); // same statement with different data values

}
st.close();
conn.close();





 finally
          {
              if (conn != null)
              {
                  try
                  {
                      conn.close ();
                  }
                  catch (Exception e) {  }
              }
          }
      }

or

Connection conn = null;
conn = DriverManager.getConnection (url, userName, password);
while (a.b()) {
  Statement st = conn.createStatement();
  st.executeUpdate(blah blah); //same statement with different data values
  st.close();
}
conn.close();




  finally
          {
              if (conn != null)
              {
                  try
                  {
                      conn.close ();

                  }
                  catch (Exception e) {  }
              }
          }
      }

Answer 1

Creating the statement outside the loop is cleaner, and may be somewhat faster, though you’d need to profile in order to see if it makes much difference in your case.

If the loop is doing the same thing with different data values, I would prefer PreparedStatement for speed.