Question

Why in code like below is the .NET compiler not able to establish that all code paths do return a value?

bool Test(bool param) {
    bool test = true;
    if (param)
        test = false;
    else
        test = false;
    if (!test)
        return false;
}

error CS0161: Not all code paths return a value!

The code can be refactored – but the compiler is not suggesting that. Yet all return paths are covered – so why does the compiler complain that they are not?

Edit: I guess the conclusion here is that:

(error CS0161) + (all code paths obviously return a value) => refactor code.  

Once you get the habit of that translation I guess everything is ok.

Answer 1

From the C# Language Specification 4.0 included with Visual Studio 2010.

10.6.10 “Method body”:

When the return type of a method is not void, each return statement in
that method’s body must specify an expression that is implicitly
convertible to the return type. The endpoint of the method body of a
value-returning method must not be reachable. In other words, in a
value-returning method, control is not permitted to flow off the end
of the method body.

The definition of reachability is here (emphasis added):

8.1 “End points and reachability”:

If a statement can possibly be reached by execution, the statement is
said to be reachable. Conversely, if there is no possibility that a
statement will be executed, the statement is said to be unreachable.

…

To determine whether a particular statement or end point is reachable,
the compiler performs flow analysis according to the reachability
rules defined for each statement. The flow analysis takes into account
the values of constant expressions (§7.19) that control the behavior
of statements, but the possible values of non-constant expressions
are not considered.

Since !test isn’t a constant expression (even though it will always evaluate to true), the compiler is obliged to not consider it in the flow analysis. One reason (maybe the only reason) for this restriction is that performing this kind of flow analysis is impossible in the general case.

To get rid of the error, you’ll need to have another return statement, either in an else clause or unconditionally at the end of the method.