Question

Why is my method only returning the first row of my table? I can’t understand why and it’s driving me nuts. I’m sure it’s something very simple.

public function getTitlesForRegistrationForm() {
    $result = $this->_db->query("SELECT UserTitleID, UserTitleName FROM UserTitles");
    $i=0;
    $array[0] = "No result";
    foreach($result->fetch(PDO::FETCH_ASSOC) as $row){
        $array[$i] = $row;
        $i++;
    }
    return $array;
}

Thanks.

Answer 1

You need to fetch() inside a while loop. It will return only one row each time it is called.

I’ve also taken the liberty of refactoring away your $i counter. Instead the No result is appended onto the array in the first position (for whatever purpose you planned to use it), and subsequent rows are appended on with [].

public function getTitlesForRegistrationForm() {
    $array = array();
    $result = $this->_db->query("SELECT UserTitleID, UserTitleName FROM UserTitles");

    // Why are you putting No Result onto the array?
    // I've left it in, but it doesn't make sense to me.
    $array[] = "No result";
    while ($row = $result->fetch(PDO::FETCH_ASSOC)){
        $array[] = $row;
    }
    return $array;
}