Yesterday when i checked out the latest version of our internal tool i saw about 30+ new versions. This got me curious since i thought that somebody finally fixed those annoying bugs and added that feature i was waiting for so long… and guess what? None of this happened, someone just thought it would be nice to update some headers and do a minor adjustment of two or three functions. Everything in a separate commit. Great.
This raised a discussion in our team – should this be considered ok, or should we prohibit such “abuse”? Arguably this really could fit in one or two commits, but 30 seems to much. How should this be handled – what is the best practice?
You should be committing any time you make a change and are about to move on to the next one.
You shouldn’t commit anything that stops the project from building.
You should be filling in the commit message so people know what changes have been made.
That’ll do for me.. I don’t assume something has been done unless I see it in the commit message…