Question

Here it is:

//Disable KeyboardNavigation
document.getElementById("author").onfocus = function() { 
document.onkeyup = null;
};
document.getElementById("email").onfocus = function() { 
document.onkeyup = null;
};
document.getElementById("url").onfocus = function() {
document.onkeyup = null;
};
document.getElementById("comment").onfocus = function() {
document.onkeyup = null;
};

//Enable KeyboardNavigation
document.getElementById("author").onblur = function() {
document.onkeyup = KeyCheck;
};
document.getElementById("email").onblur = function() { 
document.onkeyup = KeyCheck;
};
document.getElementById("url").onblur = function() { 
document.onkeyup = KeyCheck;
};
document.getElementById("comment").onblur = function() { 
document.onkeyup = KeyCheck;
};

I believe it’s definitely possible to write a better code with a loop but I really don’t know how to make it work. I tried the following:

var formfields= ["author", "email", "url", "comment"];
for (i=1; i<=3; i++){
//Don't really know what to put in here.
}

Thank you in advance for your help!

EDIT : Whole code is below. You should know that I got some help to get to this result:

document.onkeyup = KeyCheck;       

var pages = [
"http://", 
"http://", 
"http://", 
"http://", 
"http://"];

function leftarrowpressed() {
location.href = pages[ Math.max(0, 0 - 1) ]; 
//The second '0' here changes from 0 to 4, according to the page.
}

function rightarrowpressed() {
location.href = pages[ Math.min(pages.length - 1, 0 + 1) ];
//The second '0' here changes from 0 to 4, according to the page.
}

function KeyCheck(e)
{
   var KeyID = (window.event) ? event.keyCode : e.keyCode;

   switch(KeyID)
   {

// left arrow key
     case 37:
     leftarrowpressed();    
      break;

//  right arrow key
      case 39:
      rightarrowpressed(); 
      break; 
   }
}

Hope this can help a little more. By the way, thank you everyone. I really don’t know which solution to choose.

Answer 1

It looks like what you are doing is trying to prevent keystrokes in an input element from affecting navigation. What you could do instead is check event.target in KeyCheck and only perform the action if it was not triggered by an input element.

function KeyCheck(e) {
    var target = e ? e.target : event.srcElement, //standards vs IE
        tagname = target.tagName.toLowerCase();
    if( tagname !== "input" && tagname !== "textarea" && tagname !== "select") {
        //Not from an input, NAVIGATE!
    }
}