Question

Hey im trying to validate a char to limit it to accpeting an m or f for male or female. But it doesnt pass the while condition even when m or f is pressed and keeps looping the question.

Can anybody help me with this.
Thanks in advance.
Here is my code:

char Validator :: getChar(string q)
{
    char input;
    do
    {
        cout << q.c_str() << endl;
        cin >> input;
    }
    while(!isalpha(input) && "M"||"F"||"m"||"f");
    return input;
}

Answer 1

The "M"||"F"||"m"||"f" part of your code doesn’t do what you think it does. What it does is check the ADDRESSES of those string constants. Since they are all non-NULL, this expression simply returns true, so your condition, essentially becomes: while(!isalpha(input) && true) which is the same as while(!isalpha(input)).

Try this instead:

char Validator::getChar(const string &q)
{
    char input = 0;

    do
    {
        cout << q << endl;
        cin >> input;
    }
    while((input != 'M') && (input != 'F') && (input != 'm') && (input != 'f'));

    return input;
}