Question

I am running the leaks tool in instruments on a device. I am getting leaks of MKReverseGeocoder, MKReverseGeocoderInternal, and NSCFString (Points to -(void)reverseGeocoder: didFindPlacemark). I have been working on these leaks for over 2 days and cannot find a solution. If anyone can point me in the right direction I would be very gracious.

.H

@interface ReviewViewController : UIViewController <MKMapViewDelegate, MKReverseGeocoderDelegate,MKAnnotation > {
    IBOutlet UIImageView *_changingStationIV;
    IBOutlet UIImageView *_feedingAreaIV;
    IBOutlet UIImageView *_highChairIV;
    IBOutlet MKMapView *_mapView;
    MKReverseGeocoder *_reverseGeocoder;
    SGFeature *_place;
    MKPlacemark *_loc;

}

@property(nonatomic,retain)IBOutlet UIImageView *changingStationIV;
@property(nonatomic,retain)IBOutlet UIImageView *feedingAreaIV;
@property(nonatomic,retain)IBOutlet UIImageView *highChairIV;
@property(nonatomic,retain)IBOutlet MKMapView *mapView;
@property(nonatomic,retain) MKReverseGeocoder *reverseGeocoder;
@property(nonatomic,retain) SGFeature *place;
@property(nonatomic,retain) MKPlacemark *loc;

@end

.M

        @implementation ReviewViewController
     @synthesize changingStationIV=_changingStationIV,feedingAreaIV=_feedingAreaIV, highChairIV= _highChairIV, reverseGeocoder= _reverseGeocoder, mapView=_mapView,loc=_loc,coordinate=_coordinate,place=_place;

     // Implement viewDidLoad to do additional setup after loading the view, typically from a nib.
    - (void)viewDidLoad {
        [super viewDidLoad];
        NSLog(@"ViewDidLoad");

    NSLog(@"CURRENT PLACE %@",  [[self.place asDictionary] description]);

    NSDictionary *props = [self.place properties];

    self.title = [props objectForKey:@"name"];

    NSLog(@"changingStation: %@", [props objectForKey:@"changingStation"]);

    NSLog(@"feedingArea: %@", [props objectForKey:@"feedingArea"]);

    NSLog(@"highChair: %@", [props objectForKey:@"highChair"]);

    if ([[props objectForKey:@"changingStation"] boolValue]==YES) {
        self.changingStationIV.image = [UIImage imageNamed:@"check.png"];
    }else {
        self.changingStationIV.image = [UIImage imageNamed:@"x.png"];
    }
    if ( [[props objectForKey:@"feedingArea"] boolValue]==YES) {
        self.feedingAreaIV.image = [UIImage imageNamed:@"check.png"];
    }else {
        self.feedingAreaIV.image = [UIImage imageNamed:@"x.png"];
    }
    if ( [[props objectForKey:@"highChair"] boolValue]==YES) {
        self.highChairIV.image = [UIImage imageNamed:@"check.png"];
    }else {
        self.highChairIV.image = [UIImage imageNamed:@"x.png"];
    }

    SGPoint *point = (SGPoint*)[self.place geometry];
    CLLocationCoordinate2D locCoord = CLLocationCoordinate2DMake(point.latitude, point.longitude);
    NSDictionary *locDict = [NSDictionary dictionaryWithObject:[props objectForKey:@"name"] forKey:@"Country"];
    self.loc = [[MKPlacemark alloc] initWithCoordinate:locCoord addressDictionary:locDict];
    [self.mapView addAnnotation:self.loc];


    MKUserLocation *userLocation = self.mapView.userLocation;
    CLLocationCoordinate2D coord = userLocation.location.coordinate;
    [self.mapView setCenterCoordinate:coord animated:YES];

    MKCoordinateRegion region;
    MKCoordinateSpan span;
    region.center = locCoord;
    span.latitudeDelta =0.005334;
    span.longitudeDelta = 0.011834;
    region.span = span;

    [self.mapView setCenterCoordinate:locCoord animated:YES];
    [self.mapView setRegion:region animated:YES];


        self.reverseGeocoder = [[MKReverseGeocoder alloc] initWithCoordinate:locCoord];
        self.reverseGeocoder.delegate = self;
            [self.reverseGeocoder start];



    }


        -(void)reverseGeocoder:(MKReverseGeocoder *)geocoder didFailWithError:(NSError *)error{

        }

        -(void)reverseGeocoder:(MKReverseGeocoder *)geocoder didFindPlacemark:(MKPlacemark *)placemark{

                self.mapView.userLocation.title = placemark.title;

        }   


        - (void)didReceiveMemoryWarning {
            // Releases the view if it doesn't have a superview.
            [su

per didReceiveMemoryWarning];

        // Release any cached data, images, etc. that aren't in use.
    }

    - (void)viewDidUnload {
        [super viewDidUnload];
        // Release any retained subviews of the main view.
        // e.g. self.myOutlet = nil;

    NSLog(@"ViewDidUnload");


        self.changingStationIV =nil;
        self.feedingAreaIV=nil;
        self.highChairIV=nil;
        self.reverseGeocoder=nil;
        self.place=nil;
        self.loc=nil;


    }


    - (void)dealloc {

        NSLog(@"Review-Dealloc");


        self.reverseGeocoder=nil;
        self.mapView=nil;
        self.changingStationIV =nil;
        self.feedingAreaIV=nil;
        self.highChairIV=nil;
        self.place=nil;
        self.loc=nil;


        [super dealloc];

    }


    @end

Answer 1

You are certainly leaking memory here:

    self.loc = [[MKPlacemark alloc] initWithCoordinate:locCoord 
                                     addressDictionary:locDict];

Since you have defined loc as a retain property, assigning to it will call retaing on the argument, and you’ll end up with a MKPlacemark that ware retained and never released.

I would change that line as follows:

    self.loc = [[[MKPlacemark alloc] initWithCoordinate:locCoord 
                                     addressDictionary:locDict] autorelease];

Also, check carefullly your code for this pattern, since as @omz suggests, you are doing it also when assigning to reverseGeocoder.