Question

I am trying to make an if statement in javascript that will do something if the variable does not equal one of a few different things. I have been trying many different variations of the OR operator, but I cant get it to work.

 if(var != "One" || "Two" || "Three"){
    // Do Something
    }

Any ideas? Thanks!

Update:

I have tried this before:

 if(var != "One" || var != "Two" || var != "Three"){
    // Do Something
    }

For some reason it does not work. My variable is pulling information from the DOM i dont know if that would effect this.

Actual Code

// Gets Value of the Field (Drop Down box)
var itemtype = document.forms[0].elements['itemtype' + i];

    if(itemtype.value != "Silverware" || itemtype.value != "Gold Coins" || itemtype.value != "Silver Coins"){   
// Do Something
        }

Answer 1

Your expression is always true, you need:

if(!(myVar == "One" || myVar == "Two" || myVar == "Three")) { 
  // myVar is not One, Two or Three
} 

Or:

if ((myVar != "One") && (myVar != "Two") && (myVar != "Three")) {
  // myVar is not One, Two or Three
}

And, for shortness:

if (!/One|Two|Three/.test(myVar)) {
  // myVar is not One, Two or Three
}
// Or:
if (!myVar.match("One|Two|Three")) {
  // ...
}

More info:

• De Morgan’s Laws

Edit: If you go for the last approaches, since the code you posted seems to be part of a loop, I would recommend you to create the regular expression outside the loop, and use the RegExp.prototype.test method rather than String.prototype.match, also you might want to care about word boundaries, i.e. “noOne” will match “One” without them…