Question

I am working on a php mysql connect script.
I wanted it to use functions so I can keep a track what is what, so Mysql connect got one function.
When I run it, I get first “No database selected” and when I specify it manually, it says “Access denied for @ localhost”.

Code

<?php
/* Mysql Data */
$MySqlUser = "root";
$MySqlPass = "**********";
$MySqlHost = "localhost";
$MySqlDataBase = "serveradmin";
/* End Mysql Data */
function MySqlConnect() {
    $Connect = mysql_connect($MySqlHost, $MySqlUser, $MySqlPass);
    $Database = mysql_select_db($MySqlDataBase);
    if (!$Connect | !$Database) {
        die("Cannot connect ".mysql_error());
    }
}
MySqlConnect()
?>

So the problem, what causes this? I want the script to be nice and clean, and not sure if function() causes it.

Answer 1

This will fix it, but please look into PDO or mysqli

<?php
/* Mysql Data */
$MySqlUser = "root";
$MySqlPass = "**********";
$MySqlHost = "localhost";
$MySqlDataBase = "serveradmin";
/* End Mysql Data */
function MySqlConnect($MySqlUser, $MySqlPass, $MySqlHost, $MySqlDataBase ) {
    $Connect = mysql_connect($MySqlHost, $MySqlUser, $MySqlPass);
    $Database = mysql_select_db($MySqlDataBase);
    if (!$Connect | !$Database) {
        die("Cannot connect ".mysql_error());
    }
    return $Database;
}
$Database = MySqlConnect($MySqlUser, $MySqlPass, $MySqlHost, $MySqlDataBase );
?>