Question

i can’t find any mistakes in my code.
here i’m trying to pick all numbers from the string:
(just to simplify the example,, i want to pick numbers that will satisfy some condition)
i use Queue cause i don’t want to deal with array’s indexes.

        Console.Write("enter string: ");
        string s = Console.ReadLine();
        char[] array = s.ToCharArray();
        Queue<char> q = new Queue<char>();

        for (int i = 0; i < array.Length; i++)
        {
            q.Enqueue(array[i]);
        }

        char[] new_array = new char[q.Count];
        for (int i = 0; i < q.Count; i++)
        {
            new_array[i] = q.Dequeue();
        }

        Console.WriteLine(new String(new_array));    

Input string: 123456
And the output is a little weird:
123

another input: 123
output: 12

of course i made some mistake) but everything seems to be OK
Thank YOU in advance

Answer 1

The problem is the second loop:

    for (int i = 0; i < q.Count; i++)
    {
        new_array[i] = q.Dequeue();
    }

As q.Count decrements on every loop iteration, and i increases on every interation, you get only half of the elements.

try something like:

    for (int i = 0; q.Count > 0; i++)
    {
        new_array[i] = q.Dequeue();
    }

also consider: Queue.toArray