Question

I don’t use DataSets much. Usually find myself using an ORM or just a basic sqlReader.Read() followed by some GetValues(). I’m working on some legacy code that has DataSets all over the place, and while fixing a bug was trying to DRY some of it up.

However, I can’t seem to actually get the data loaded into a non-typed DataSet.

public static DataSet ExecuteStoredProcedure(string storedProcedure, DBEnum db, IEnumerable<SqlParameter> parameters)
{
    DataSet result = new DataSet();
    using (SqlConnection connection = SqlHelper.GetSqlConnection(db))
    {
        SqlCommand command = connection.CreateCommand();
        command.CommandType = CommandType.StoredProcedure;
        command.CommandText = storedProcedure;

        if (parameters != null)
            foreach (SqlParameter parameter in parameters)
                command.Parameters.Add(parameter);

        connection.Open();
        DataTable table = new DataTable();
        using (SqlDataReader reader = command.ExecuteReader())
        {
            table.Load(reader);
        }
        result = table.DataSet; // table.DataSet is always empty!
   }
   return result;
}

I assumed table.Load(reader) does all the necessary reader.Read() calls … but I went ahead and tried it both with and without reader.Read() before the table.Load(), to no avail.

I know that the stored procedure being called is actually returning data. If I do something like this, I see the data just fine:

using(SqlDataReader reader = command.ExecuteReader())
{
    reader.Read();
    object test = reader.GetValue(0); // returns the expected value
}

Seems like I’m missing something simple here, but I’ve been scratching my head over this one for a while now.

This is in .NET 3.5.

Answer 1

If you can, I would suggest using a SqlDataAdapter to populate the DataTable

using(SqlDataAdapter sqlDA = new SqlDataAdapter(command))
{
    sqlDA.Fill(table);
}