Question

I have a class that creates a vector of objects. In the deconstructor for this class I’m trying to deallocate the memory assigned to the objects. I’m trying to do this by just looping through the vector. So, if the vector is called maps I’m doing:

Building::~Building() {
    int i;
    for (i=0; i<maps.size(); i++) {
        delete[] &maps[i];
    }
}

When I run this the program segfaults while deallocating memory. I think what I’m doing is actually deleting the array storing the objects and not the objects themselves. Is this correct? If not any ideas as to what I’m doing wrong?

Answer 1

It depends on how vector is defined.

If maps is a vector<myClass*> you delete each element with something similar to:

for ( i = 0; i < maps.size(); i++)
{
    delete maps[i];
}

If maps is a vector<myClass> I don’t think you need to delete the individual elements.