Question

I have a number of simple controller classes that use Doctrine’s entity manager to retrieve data and pass it to a view.

public function indexAction() {
    $pages = $this->em->getRepository('Model_Page')->findAll();
    $this->view->pages = $pages;
}

What exactly should we be testing here?

• I could test routing on the action to ensure that’s configured properly
• I could potentially test that the appropriate view variables are being set, but this is cumbersome

The findAll() method should probably be in a repository layer which can be tested using mock data, but then this constitutes a different type of test and brings us back to the question of

What should we be testing as part of controller tests?

Answer 1

Controller holds core logic for your application. Though simple “index” controller actions don’t have any specific functions, those that verify/actively use data and generate viewmodels have pretty much the most functionality of the system.

For example, consider login form. Whenever the login data is posted, controller should validate login/password and return: 1) to index page whenever logins are good. Show welcome,{user} text. 2) to the login page saying that login is not found in db. 3) to the login page saying that password is not found in db.

These three types of outputs make perfect test cases. You should validate that correct viewmodels/views are being sent back to the client with the appropriate actions.

You shouldn’t look at a controller like at something mysterious. It’s just another code piece, and it’s tested as any other code – any complicated logic that gives business-value to the user should be tested.

Also, I’d recommend using acceptance testing with framework like Cucumber to generate meaningful test cases.