Question

I have an array called $blocks that print_r() function on it will result:

Array ( [0] => template.header [1] => error [2] => emails.addEmail )

and here is my code is:

if(count($blocks)) {
    foreach ($blocks as $block) {
        echo $block;
        $parts = explode('.', $block);
        if (count($parts) > 1) {
            list($folder, $file) = $parts;
            $folder = $folder . '/';
            echo BASE . '/blocks/' . $folder . $file . '.php';
        } else {
            echo BASE . '/blocks/' . $file . '.php';
        }
    }
    $parts = null;
}

but it’s acting strangely and echo on line 3 gives me this:

template.header
error
error

The third one must be emails.addEmail but it’s duplicating the second one.

Can anyone tell me what is wrong with my code?

Update: I removed @ and replaced it with if (count($parts) > 1). Sorry about that guys. But it doesn’t have anything to do with my problem! Still need help…

Update 2: I was using $block variable somewhere before this code and it was connected by reference to another thing. The problem got fixed by changing that variable name. Thanks you guys for your help.

Answer 1

My first impression was that some (included) file is somehow manipulating either the $blocks array or $block itself. You should avoid referencing variables that way; keep variable changes close to the scope where they’re being used.

Other issues I found:

echo BASE . '/blocks/' . $file . '.php';

Should be:

echo BASE . '/blocks/' . $block . '.php';

Because $file only gets set if $parts contains at least two elements.

Also to test if the split has explode() returned two items:

if (isset($parts[1])) { ... }

Or:

if (count($parts) > 1) { ... }

Working example: http://codepad.viper-7.com/6oNhBv