Question

I have an XDocument with a number of elements/child elements etc and I’d like to make the Value of each element UpperCase.

doc.Descendants().ToList().ForEach(f => f.Value = f.Value.ToUpper());

doesn’t work because it concatenates ALL the values (as upper) into the parent element.

Answer 1

LINQ expressions shouldn’t normally modify the value of the source. They should only return new values (think them as a filter… You put something in, something different comes out)

foreach (var desc in doc.Descendants()) {
    var nodes = desc.Nodes().Where(p => p.NodeType == XmlNodeType.Text);

    foreach (XText node in nodes) {
        node.Value = node.Value.ToUpper();
    }
}