Question

i have defiened a structure here

struct Owner{

char* ownerName;char* fatherName;char* address;};


void registerV(Owner *);

main(){

here im initializing the owner

struct Owner owner;

  owner.ownerName="Imran Ali";
  owner.fatherName="Ali Khokhar";
  owner.adress="KhushalPura";
  registerV(&owner);

}

In this function i am taking input from the user which i have to display in the main section using another function. But when i try to do so i get garbage values

void registerV(struct Owner *ownerPtr)
{

 char buyersName[50];
 char fatherName[50];
 char adress[100];

 cin.getline(buyersName, 50);
 cout << " Enter Buyers Name : " ;
 cin.getline(buyersName, 50);
 (*ownerPtr).ownerName=buyersName;

 cout << " Enter Fathers Name : " ;
 cin.getline(fatherName, 50);
 (*ownerPtr).fatherName=fatherName;

 cout << " Enter Adress : " ;
 cin.getline(adress, 100);
 (*ownerPtr).adress=adress;
}

When i try to view the values from the main function i get garbage values. Please help me.

Answer 1

The struct keyword before Owner owner; Is unnecessary.

Instead of dereferencing pointers and accessing their members with (*pStruct).member you can access them directly with pStruct->member.

If you want to stick with char pointers i would personally just place the body of your “register” function in main.

And if you still need the function you should copy the value by using std::strcpy from your temporaries to the members.