Question

I have defined the folloing method to sort an array:

public int[] BubbleSort(int[] ints)
{
    for (int i = 0; i < ints.Length; i++)
    {
        if (ints[i] > ints[i + 1])
        {
            int tempValue = ints[i];
            ints[i] = ints[i + 1];
            ints[i + 1] = tempValue;         
        }
    }
    return ints;               
}

However, my implementation above is throwing System.IndexOutOfRangeException : Index was outside the bounds of the array. What might be the problem?

Answer 1

Go to .Length - 1 instead. Also, with bubble sort, you need to iterate over the array until no more elements should be swapped (this is what makes bubble sort so inefficient):

public int[] BubbleSort(int[] ints)
{            
    bool swapped = true;
    while (swapped) 
    {
        swapped = false;
        for (int i = 0; i < ints.Length - 1; i++)
        {
            if (ints[i] > ints[i + 1])
            {
                swapped = true;
                int tempValue = ints[i];
                ints[i] = ints[i + 1];
                ints[i + 1] = tempValue;
            }     
        }
    }

    return ints;               
}