Question

I have multithreaded application as I ask here.
I want to terminate the thread, and start a new one when following method is called.

procedure TFRABData.RefreshDataset;
var
  GridUpdater: TGridUpdater;
begin
  if Assigned(updaterThread) and (updaterThread <> nil) then
  begin
    updaterThread.Terminate;
  end;
  GridUpdater := TGridUpdater.Create(True);
  GridUpdater.OwnerForm := Self;
  updaterThread := GridUpdater;
  GridUpdater.FreeOnTerminate := False;
  GridUpdater.Start;
  CodeSite.Send('RefreshDataset executed');
end

but, when FreeOnTerminate set to True, I get Access Violation, but when FreeOnTerminate set to False, I get memory leak. How to free the thread?

Answer 1

And in addition to RRUZ’s answer, to let it work with FreeOnTerminate = False:

Terminate just sets the flag, it does nothing more.

Change

  if Assigned(updaterThread) and (updaterThread <> nil) then 
  begin 
    updaterThread.Terminate; 
  end; 

to

  if Assigned(updaterThread) then 
  begin 
    updaterThread.Free; 
  end; 

Free will call Terminate and WaitFor subsequently to eliminate your memory leak.