Question

I have the following code, it will create the logfile on both platforms, but it will only write the output to the windows logfile.

import os                       

logdir = os.getenv("logs")                          
logfile = 'script_list.log'
path = (raw_input("Enter dir: "))                                   
if os.name == "posix":
    log = open("//".join([logdir,logfile]), 'w')                        
else:
    log = open("\\".join([logdir,logfile]), 'w')                        
for dirpath, dirname, filenames in os.walk(path):           
    for filename in [f for f in filenames]: 
        if os.name == "posix":
            log.write(str(dirpath)+ "//" + str(filename) + "\n")    
        else:
            log.write(str(dirpath)+ "\\" + str(filename) + "\n")    
print '\nYour logfile ' + logdir + '\\' + logfile + ' has been created'

Thanks in advance

Answer 1

I suggest you replace

if os.name == "posix":
    log = open("//".join([logdir,logfile]), 'w')                      
else :
    log = open("\\".join([logdir,logfile]), 'w')
...
    for filename in [f for f in filenames]:
        if os.name == "posix":
            log.write(str(dirpath)+ "//" + str(filename) + "\n")    
        else:
            log.write(str(dirpath)+ "\\" + str(filename) + "\n")    

with

log=open(os.path.join(logdir, logfile), 'w')
...
    for filename in filenames:
        log.write(os.path.join(dirpath, filename)+'\n')

Or even better, use

logfilename=os.path.join(logdir, logfile)
log=open(logfilename, 'w')

...

print "Your logfile", logfilename, "has been created."

As @Lycha says, it’s a good idea to close your file again. So your construct would be

with open(logfilename, 'w') as log:
    ...