Question

I have the following try-catch statement and I do not want to not throw the exception if the message property contains ‘My error’ in the text.

How can I programmatcially accomplish this? Also, would this be considered code-smell?

try
{
}
catch(Exception e)
{
    if(e.Messages.Contains("My error"))
    {
       //want to display a friendly message and suppress the exception
    }
    else
    {
        throw e;
    }
}

Answer 1

You should be catching the specific exception you’re looking for. Quite frankly, that code is shocking. You should have something like …

public class MyCoolException : Exception {
    public MyCoolException(string msg) : base(msg) {}
}

public void MyCoolMethod() {
    // if bad things happen
    throw new MyCoolException("You did something wrong!");
}

Then later in your code you can use it like …

try {
    MyCoolMethod();
} catch (MyCoolException e) {
    // do some stuff
}